errors: return all token fetch related errors as structured #380
+25
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now all non-HTTP errors are returned as plain error with combined text messages into single string, e.g.: oauth2: cannot fetch token: Post https://oauth2.googleapis.com/token: read tcp 10.0.6.7:46650->172.217.212.95:443: read: connection reset by peer So caller doesn't have a chance to check easily if underlying error was retriable (e.g. net.IsTemporary() or DNS error) or not. This patch wraps ALL errors as RetrieveError with additional Err field in case it was non-http error.
|
This PR (HEAD: 6b30711) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/oauth2/+/172877 to see it. Tip: You can toggle comments from me using the |
|
Being able to inspect errors to determine their temporary state is an essential need in order to build resilient systems, and currently this issue is preventing this. Would the maintainers of this repo accept a modified version of this patch with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now all non-HTTP errors are returned as plain error with combined
text messages into single string, e.g.:
oauth2: cannot fetch token: Post https://oauth2.googleapis.com/token: read tcp 10.0.6.7:46650->172.217.212.95:443: read: connection reset by peer
So caller doesn't have a chance to check easily if underlying error was
retriable (e.g. net.IsTemporary() or DNS error) or not.
This patch wraps ALL errors as RetrieveError with additional Err field
in case it was non-http error.